Skip to content

Add support for resolving Optional<Pageable> #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add support for resolving Optional<Pageable> #3156

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Sep 19, 2024

Fix GH-3155

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 19, 2024
@quaff quaff mentioned this pull request Sep 19, 2024
Closed
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 23, 2024
@mp911de
Copy link
Member

mp911de commented Sep 23, 2024

We do not have a case of an absent Pageable, even an unpaged Pageable can contain some sort. Spring Data represents an empty pageable through Pageable.unpaged() and we do not want to introduce another alternative as that makes its usage much more difficult and introduces ambiguity over how the API should be used.

@mp911de mp911de closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PageableHandlerMethodArgumentResolver should resolve Optional<Pageable> arguments
3 participants
@quaff @mp911de @spring-projects-issues