Skip to content

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Apr 28, 2024

  1. Specification should be annotated with @FunctionalInterface
  2. SpecificationUnitTests shouldn't be Serializable

1. `Specification` should be annotated with `@FunctionalInterface`
2. `SpecificationUnitTests` shouldn't be `Serializable`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2024
@mp911de mp911de self-assigned this Apr 29, 2024
@mp911de mp911de added the status: on-hold We cannot start working on this issue yet label Jun 10, 2024
@mp911de
Copy link
Member

mp911de commented Jun 10, 2024

Putting this on hold as we need to overhaul the Specification infrastructure before adding more changes to it.

@mp911de mp911de force-pushed the main branch 2 times, most recently from 52ee55f to 61e6d36 Compare October 9, 2024 07:35
@mp911de mp911de added type: task A general task and removed status: on-hold We cannot start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Jan 31, 2025
@mp911de mp911de added this to the 3.4.3 (2024.1.3) milestone Jan 31, 2025
mp911de pushed a commit that referenced this pull request Jan 31, 2025
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
mp911de added a commit that referenced this pull request Jan 31, 2025
Refine deprecation warnings.

See #3452
@mp911de mp911de closed this in aea1a03 Jan 31, 2025
mp911de added a commit that referenced this pull request Jan 31, 2025
Refine deprecation warnings.

See #3452
mp911de pushed a commit that referenced this pull request Jan 31, 2025
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
@mp911de
Copy link
Member

mp911de commented Jan 31, 2025

Thank you for your contribution. That's merged, polished, and backported now.

mp911de pushed a commit that referenced this pull request Mar 17, 2025
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
mp911de pushed a commit that referenced this pull request Apr 14, 2025
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
mp911de pushed a commit that referenced this pull request May 16, 2025
Add missing `@FunctionalInterface` to Specification interfaces.
`SpecificationUnitTests` shouldn't be `Serializable`.

Closes #3452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants