Skip to content

Optimize entity deletion in SimpleJpaRepository #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Optimize entity deletion in SimpleJpaRepository #3564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bbbe70
Optimize entity deletion in SimpleJpaRepository.
Seol-JY Aug 7, 2024
dbef2ed
Add author
Seol-JY Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...pa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
* @author Yanming Zhou
* @author Ernst-Jan van der Laan
* @author Diego Krupitza
* @author Seol-JY
*/
@Repository
@Transactional(readOnly = true)
Expand Down Expand Up @@ -196,14 +197,16 @@ public void delete(T entity) {

Class<?> type = ProxyUtils.getUserClass(entity);

T existing = (T) entityManager.find(type, entityInformation.getId(entity));

// if the entity to be deleted doesn't exist, delete is a NOOP
if (existing == null) {
if (entityManager.contains(entity)) {
entityManager.remove(entity);
return;
}

entityManager.remove(entityManager.contains(entity) ? entity : entityManager.merge(entity));
// if the entity to be deleted doesn't exist, delete is a NOOP
T existing = (T) entityManager.find(type, entityInformation.getId(entity));
if (existing != null) {
entityManager.remove(entityManager.merge(entity));
}
}

@Override
Expand Down
Loading