Skip to content

Fix Hql-Queries using CEILING and LN. #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix Hql-Queries using CEILING and LN. #3711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
346a06e
Fix Hql-Queries using CEILING and LN.
coderesting Dec 11, 2024
bff9fc2
Fill the author field.
coderesting Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion spring-data-jpa/src/main/antlr4/org/springframework/data/jpa/repository/query/Hql.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ grammar Hql;
* management of complex rules in the generated Visitor. Finally, there are labels applied to rule elements (op=('+'|'-')
* to simplify the processing.
*
* @author Greg Turnquist
* @author Greg Turnquist, Yannick Brandt
* @since 3.1
*/
}
Expand Down Expand Up @@ -1133,6 +1133,7 @@ reservedWord
| BY
| CASE
| CAST
| CEILING
| COLLATE
| CONTAINS
| COUNT
Expand Down Expand Up @@ -1206,6 +1207,7 @@ reservedWord
| LIMIT
| LIST
| LISTAGG
| LN
| LOCAL
| LOCAL_DATE
| LOCAL_DATETIME
Expand Down
12 changes: 11 additions & 1 deletion ...pa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryRendererTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
*
* @author Greg Turnquist
* @author Christoph Strobl
* @author Mark Paluch
* @author Mark Paluch, Yannick Brandt
* @since 3.1
*/
class HqlQueryRendererTests {
Expand Down Expand Up @@ -1509,6 +1509,16 @@ select round(count(ri) * 100 / max(ri.receipt.positions), 0) as perc
});
}

@Test
void ceilingFunctionShouldWork() {
assertQuery("select ceiling(1.5) from Element a");
}

@Test
void lnFunctionSouldWork() {
assertQuery("select ln(7.5) from Element a");
}

@Test // GH-2981
void cteWithClauseShouldWork() {

Expand Down
Loading