refactor: Improve exists check in JpaQueryExecution #3715
Closed
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using getResultStream and findFirst
spring-projects-issues
added
the
status: waiting-for-triage
|
|
mp911de
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated getResultList().isEmpty() to getResultStream().findFirst().isPresent() for checking query existence.
Improved performance by processing only the first result.
Reason
It seems that this method is only meant to check if the query exists. Therefore, fetching the entire query result does not seem necessary.
Avoids loading all results into memory, reducing overhead and improving efficiency.
Testing
Verified with existing test cases, ensuring identical results.
Review Request
Please review and share any feedback. 🙇♂️