Skip to content

Refactor: Remove unused query parameter in getCountQuery method #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor: Remove unused query parameter in getCountQuery method #3719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...jpa/src/main/java/org/springframework/data/jpa/repository/query/JpaCountQueryCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,15 @@ protected CriteriaQuery<? extends Object> createCriteriaQuery(CriteriaBuilder bu
@Override
@SuppressWarnings("unchecked")
protected CriteriaQuery<? extends Object> complete(@Nullable Predicate predicate, Sort sort,
CriteriaQuery<? extends Object> query, CriteriaBuilder builder, Root<?> root) {
CriteriaQuery<? extends Object> query, CriteriaBuilder builder, Root<?> root) {

CriteriaQuery<? extends Object> select = query.select(getCountQuery(query, builder, root));
CriteriaQuery<? extends Object> select = query.select(getCountQuery(builder, root));
return predicate == null ? select : select.where(predicate);
}


@SuppressWarnings("rawtypes")
private Expression getCountQuery(CriteriaQuery<?> query, CriteriaBuilder builder, Root<?> root) {
private Expression getCountQuery(CriteriaBuilder builder, Root<?> root) {
return distinct ? builder.countDistinct(root) : builder.count(root);
}
}
Loading