Skip to content

Conversation

oscarfanchin
Copy link
Contributor

@oscarfanchin oscarfanchin commented May 2, 2025

Hello, an implentation for Fixes issue #3864

I used the sample project provided in the issue description (#3864) as a base to build and validate the integration tests with SRF support.

Details

-- Introduced grammar rules for set-returning functions in FROM and JOIN clauses.
-- Updated HqlQueryRenderer to support SRF syntax.
-- Added support for SRF in For count and sort.
-- Implemented QueryRenderer logic for proper spacing in function parameter rendering.
-- Added internal tests to verify SRF parsing and rendering logic.

Notes

This is my first contribution to the Spring Data project. I'm open to feedback and happy to make any necessary adjustments or improvements.

To run the tests locally, I had to:

  • Add an explicit dependency on org.hamcrest:hamcrest to resolve a NoClassDefFoundError.
  • Temporarily ignore HqlParserUnitTests, as the ANTLR-generated parser class is always created as public, causing a mismatch with the expected package-private visibility.

These changes were not committed, as I assumed they are specific to my local environment and not required for others.

Thanks for reviewing!

  • [ X] You have read the Spring Data contribution guidelines.
  • [ X] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [ X] You submit test cases (unit or integration tests) that back your changes.
  • [ X] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 2, 2025
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 5, 2025
@mp911de mp911de self-assigned this May 5, 2025
… in HQL parser and query rendering for H7

Signed-off-by: oscarfanchin <[email protected]>
@oscarfanchin
Copy link
Contributor Author

Closing this PR in favor of version based on the updated 4.0.x branch. Please check the new PR for the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants