Fix keyset pagination with hierarchical idclass#4156
Open
JBodkin-Amphora wants to merge 2 commits intospring-projects:mainfrom
Open
Fix keyset pagination with hierarchical idclass#4156JBodkin-Amphora wants to merge 2 commits intospring-projects:mainfrom
JBodkin-Amphora wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: James Bodkin <james.bodkin+github@amphora.net>
420d0e1 to
2d5e9a3
Compare
Signed-off-by: James Bodkin <james.bodkin+github@amphora.net>
Author
|
Eclipse Link tests are now passing after changes to the entities. Also changed the lookup to loop through the attributes instead of trying to look up by type, as Eclipse Link converts the primitive type to the wrapper type inside the metamodel |
Member
|
Thanks a lot. Which version of Spring Data JPA is affected for you? (So that we can correctly apply backports). |
Author
|
I've noted the issue starting when I migrated to Spring Boot v4, which uses the 4.0.x branch in this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noted a few issues with keyset pagination when using hierarchical idclasses that I believe was introduced when Jakarta Persistence changed the
greaterThan/lessThanmethods on the criteriabuilder to take a Comparable. I've written some code to extract the attribute paths so that the underlying values can be extracted instead of the entity.Whilst writing tests for the code, I found that the
isNotNull/isNullpredicates are being applied the wrong way around. This is covered by the tests.I've noted that the Eclipse Link tests are now failing, I'm not sure if the technology supports the same hierarchical classes as I'm a Hibernate user. If it doesn't, is there a way to prevent the new repositories/entities being used for those tests?