Skip to content

Return List instead of Iterable from JdbcAggregateOperations and SimpleJdbcRepository #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Return List instead of Iterable from JdbcAggregateOperations and SimpleJdbcRepository #1897

wants to merge 3 commits into from

Conversation

@schauder
Copy link
Contributor

@schauder schauder commented Sep 25, 2024 •
edited
Loading

Closes #1623

@schauder schauder requested a review from mp911de September 25, 2024 07:36
@schauder schauder assigned schauder and mp911de and unassigned schauder Sep 25, 2024
@mp911de mp911de changed the title Return List instead of Iterable from JdbcAggregateOperations and SimpleJdbcRepository Return List instead of Iterable from JdbcAggregateOperations and SimpleJdbcRepository Oct 1, 2024
mp911de pushed a commit that referenced this pull request Oct 1, 2024
@schauder @mp911de
Return List instead of Iterable in JDBC Repositories and `JdbcAgg…
c4f62e9 
…regateOperations`.

Closes #1623
Original pull request: #1897
mp911de added a commit that referenced this pull request Oct 1, 2024
@mp911de
Polishing.
7cf81ae 
Replace code duplications with doWithBatch(…) method. Return most concrete type in DefaultDataAccessStrategy and MyBatisDataAccessStrategy.

See #1623
Original pull request: #1897
@mp911de mp911de added the type: enhancement A general enhancement label Oct 1, 2024
@mp911de mp911de added this to the 3.4 M2 (2024.1.0) milestone Oct 1, 2024
@mp911de
Copy link
Member

mp911de commented Oct 1, 2024

That's merged and polished now.

@mp911de mp911de closed this Oct 1, 2024
@mp911de mp911de deleted the issue/1623-return-lists branch October 1, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de Awaiting requested review from mp911de

1 more reviewer

@mipo256 mipo256 mipo256 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mp911de mp911de

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

3.4 RC1 (2024.1.0)

Development

Successfully merging this pull request may close these issues.

Change Iterable<T> to List<T> return types for Repository and Template API methods

4 participants

@schauder @mp911de @mipo256