Skip to content

Add missing Javadoc since in AbstractUrlHandlerMapping #33247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add missing Javadoc since in AbstractUrlHandlerMapping #33247

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jul 20, 2024

This PR adds a Javadoc @since tag for the AbstractUrlHandlerMapping.unregisterHandler().

See gh-32064

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 20, 2024
@snicoll snicoll self-assigned this Jul 21, 2024
@snicoll snicoll added type: task A general task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 21, 2024
@snicoll snicoll added this to the 6.2.0-M7 milestone Jul 21, 2024
@snicoll snicoll changed the title Add Javadoc since for AbstractUrlHandlerMapping.unregisterHandler() Add missing Javadoc since in AbstractUrlHandlerMapping Jul 21, 2024
snicoll pushed a commit that referenced this pull request Jul 21, 2024
@izeye @snicoll
Add missing Javadoc since in AbstractUrlHandlerMapping
edc356d 
See gh-33247
snicoll added a commit that referenced this pull request Jul 21, 2024
@snicoll
Polish "Add missing Javadoc since in AbstractUrlHandlerMapping"
d5abc07 
See gh-33247
@snicoll snicoll closed this in 28b044c Jul 21, 2024
@snicoll
Copy link
Member

snicoll commented Jul 21, 2024

Thanks again @izeye - there were two add methods added in this commit so I've polished the proposal to add missing @since tag for them too.

@izeye izeye deleted the gh-32064 branch July 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
6.2.0-M7
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @snicoll @spring-projects-issues