Avoid empty array allocations in AnnotationTypeMapping #33507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
in: core
sdeleuze
reviewed
Sep 9, 2024
spring-core/src/main/java/org/springframework/core/annotation/AnnotationTypeMapping.java
Outdated
Show resolved
Hide resolved
|
@kilink Any chance you could provide a feedback on my question above? If not, I plan to merge your PR without the commented change. |
Sorry, have been somewhat busy and hadn't got a chance to look at it. What you said it probably correct, I was likely just over-aggressive in trying to eliminate possible empty array allocations here. I can push up a change that removes that line. |
Avoid empty array allocations in a few places in AnnotationTypeMapping.
kilink
force-pushed
the
annotation-type-mapping-empty-array-allocations
branch
from
10e841e to
66b5741
Compare
|
I double-checked, I only see the problem in
I went ahead and reverted that line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid empty array allocations in a few places in AnnotationTypeMapping.
In a heap dump for a production app, there were a couple hundred empty int arrays referenced from AnnotationTypeMapping instances (~3kb of waste); there were also about ~60 empty MirrorSet arrays (~1kb of waste).