Simplify hasText and containsElement methods for better clarity #33572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dukbong
commented
Sep 20, 2024
dukbong
commented
- In the containsElement method, I replaced the null check with the isEmpty method to enhance readability.
- In the hasText method, I substituted the length check with isEmpty to reduce code duplication.
array == null -> isEmpty()
str == null & str.length == 0 > isEmpty()
spring-projects-issues
added
the
status: waiting-for-triage
steLen -> str.length
sbrannen
added
status: declined
sbrannen
removed
the
status: waiting-for-triage
|
Hi @dukbong, Thanks for the proposal; however, we are happy with the current implementation of these internal utility methods. In light of that, I am closing this PR. Regards, Sam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.