Skip to content

Refactor unwrapOptional method to improve readability and performance #33612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor unwrapOptional method to improve readability and performance #33612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions spring-core/src/main/java/org/springframework/util/ObjectUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,7 @@ public static boolean isEmpty(@Nullable Object obj) {
@Nullable
public static Object unwrapOptional(@Nullable Object obj) {
if (obj instanceof Optional<?> optional) {
if (optional.isEmpty()) {
return null;
}
Object result = optional.get();
Object result = optional.orElse(null);
Assert.isTrue(!(result instanceof Optional), "Multi-level Optional usage not supported");
return result;
}
Expand Down