Skip to content

Conversation

J-unStiN
Copy link
Contributor

@J-unStiN J-unStiN commented Oct 5, 2024

I modified the hardcoded '.' and '\' parts to
EXTENSION_SEPARATOR,
WINDOWS_FOLDER_SEPARATOR_CHAR.

The '\' part can be maintained by adding WINDOWS_FOLDER_SEPARATOR_CHAR
to maintain the overall consistency of the code base.

ps. This is my first Spring Framework PR, so even if there are some shortcomings, I will improve it to a good code through future activities.

EXTENSION_SEPARATOR
WINDOWS_FOLDER_SEPARATOR_CHAR.

The '\\' part can be added to WINDOWS_FOLDER_SEPARATOR_CHAR to maintain overall consistency in the codebase.
@pivotal-cla
Copy link

@J-unStiN Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 5, 2024
@pivotal-cla
Copy link

@J-unStiN Thank you for signing the Contributor License Agreement!

@sbrannen sbrannen added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 5, 2024
@sbrannen sbrannen self-assigned this Oct 5, 2024
@sbrannen
Copy link
Member

sbrannen commented Oct 5, 2024

Hi @J-unStiN,

Congratulations on submitting your first PR for the Spring Framework! 👍

Although we generally prefer to make such minor changes ourselves, I will accept this since it's your first PR.

Also, please note that we do not add @author tags for such minor changes.

Regards,

Sam

@sbrannen sbrannen changed the title Refactor -> The hardcoded '.' and '\\' parts have been modified Polish use of constants in StringUtils Oct 5, 2024
@sbrannen sbrannen added this to the 6.2.0-RC2 milestone Oct 5, 2024
@sbrannen sbrannen closed this in 32df079 Oct 5, 2024
@sbrannen
Copy link
Member

sbrannen commented Oct 5, 2024

This has been merged into main.

Thanks

@J-unStiN
Copy link
Contributor Author

J-unStiN commented Oct 5, 2024

Thank you very very much.

I will never forget this moment.

I have another question.

I don't see any methods in Spring's StirngUtils that check for empty and null values ​​via isBlank, isEmpty. I wonder if it would be okay to create one and post a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants