DurationFormatterUtils should not attempt to parse an empty duration #33669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
While testing the
DurationFormatterUtilsfunctionality, I came across a couple of issues that I'd like to address in this PREmpty String Handling in
parseMethod:""," ") is passed to theparseComposite(value)method, the result isPT0Sinstead of an exception being thrown. This doesn't seem like the correct behavior, as an empty string is an invalid input and returningPT0Scan be misleading in this case.NullPointerException (NPE) in
printMethod:printmethod does not handlenullvalues properly for theDurationparameter, resulting in aNullPointerException.Changes
nullvalues.nullDurationvalues.Exceptioninstead ofThrowableThank you for taking the time to review this PR! Please feel free to share any feedback or suggestions.