Skip to content

Polishing #33681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Polishing #33681

wants to merge 2 commits into from

Conversation

ngocnhan-tran1996
Copy link
Contributor

This PR includes:

  • Reduce else if condition. I think this make code more readable
  • Polish diamond operator usage
  • Polish Map#isEmpty usage

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 10, 2024
@sdeleuze sdeleuze self-assigned this Oct 14, 2024
@sdeleuze sdeleuze added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 14, 2024
@sdeleuze sdeleuze added this to the 6.2.0-RC2 milestone Oct 14, 2024
@sdeleuze sdeleuze changed the title Polish Polishing Oct 14, 2024
sdeleuze pushed a commit to sdeleuze/spring-framework that referenced this pull request Oct 14, 2024
@ngocnhan-tran1996 @sdeleuze
Polishing
e9d6db0 
Closes spring-projectsgh-33681
@sdeleuze sdeleuze closed this in e191c34 Oct 14, 2024
@sdeleuze
Copy link
Contributor

Merged except FastByteArrayOutputStream changes since it does not achieve consistency class-wide. Notice I do not ask a follow-up PR for FastByteArrayOutputStream.

I appreciate the contributions but we need to be mindful of reaching a certain level of added value, otherwise we could spend too much energy reviewing Spring Framework codebase polishes. So for upcoming PRs, I will ask more clear added value for refinements, and otherwise will reject the related PRs. Thanks for your undertanding.

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the improve-code branch October 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdeleuze sdeleuze

Labels
in: core Issues in core modules (aop, beans, core, context, expression) in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
6.2.0-RC2
Development

Successfully merging this pull request may close these issues.
3 participants
@ngocnhan-tran1996 @sdeleuze @spring-projects-issues