Skip to content

Polish ServletWebRequest #33698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Polish ServletWebRequest #33698

wants to merge 3 commits into from

Conversation

smartandhandsome
Copy link
Contributor

This PR includes the following changes to improve code readability:

  1. Code readability:

    • Refactored an if statement to enhance readability.
    • Removed an unnecessary else block

  2. Javadoc improvements:

    • Replaced @code with @link for the checkNotModified(String) reference to create clickable links in the Javadoc.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 14, 2024
@sdeleuze sdeleuze self-assigned this Oct 14, 2024
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 14, 2024
@sdeleuze sdeleuze added this to the 6.2.0-RC2 milestone Oct 14, 2024
@sdeleuze sdeleuze closed this in ae32227 Oct 14, 2024
@sdeleuze sdeleuze changed the title Polish Polish ServletWebRequest Oct 14, 2024
sdeleuze added a commit to sdeleuze/spring-framework that referenced this pull request Oct 14, 2024
@sdeleuze
Polish WebRequest Javadoc
bf1a965 
See spring-projectsgh-33698
sdeleuze added a commit to sdeleuze/spring-framework that referenced this pull request Oct 14, 2024
@sdeleuze
Polish WebRequest Javadoc
60978ff 
See spring-projectsgh-33698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdeleuze sdeleuze sdeleuze left review comments

Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-RC2
Development

Successfully merging this pull request may close these issues.
3 participants
@smartandhandsome @sdeleuze @spring-projects-issues