Refactor DefaultRestClient Constructor for Improved Readability and Consistency #33737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the proposal but I don't think this makes the code more readable nor helps with maintenance. |
bclozel
added
status: declined
|
Thank you for reviewing the proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored DefaultRestClient constructor and DefaultRestClientBuilder's build method.
Changes
Improved readability by aligning the order of parameters and their initialization in the DefaultRestClient constructor. (The reason for changing the order is to match the field order of the class)
Ensured consistency by renaming the only parameter whose name didn’t match its corresponding field.
Other
No functional changes.
All tests pass.