Skip to content

Conversation

@lucky8987
Copy link
Contributor

  1. Use CAS instead of synchronized to set the complete state.
  2. Reduce the synchronized range added by the callback function.

@pivotal-cla
Copy link

@lucky8987 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 1, 2024
@pivotal-cla
Copy link

@lucky8987 Thank you for signing the Contributor License Agreement!

@simonbasle simonbasle self-assigned this Nov 7, 2024
@simonbasle simonbasle added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 7, 2024
@simonbasle simonbasle modified the milestones: 6.2.x, 6.2.0 Nov 7, 2024
@simonbasle
Copy link
Contributor

Thanks for the PR @lucky8987, this looks like a good performance improvement. That close to the release, I'll review it a bit more in depth and discuss it with other team members, but I expect this should make the cut 👍

@simonbasle simonbasle removed the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Nov 7, 2024
@simonbasle simonbasle closed this in e67f892 Nov 7, 2024
@simonbasle simonbasle changed the title Optimize the range of synchronized code blocks for ResponseBodyEmitter Use optimistic locking where possible in ResponseBodyEmitter Nov 7, 2024
@lucky8987
Copy link
Contributor Author

Thanks for the PR @lucky8987, this looks like a good performance improvement. That close to the release, I'll review it a bit more in depth and discuss it with other team members, but I expect this should make the cut 👍

OK,this is my first PR and I'm really looking forward to it being accepted.

@simonbasle
Copy link
Contributor

@lucky8987 good news, then: it's been merged 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants