Skip to content

Conversation

@Yaklede
Copy link
Contributor

@Yaklede Yaklede commented Nov 6, 2024

Hello Spring Team,

I’m excited to submit this contribution, which adds coroutine-friendly extensions to enhance Kotlin support within Spring WebFlux. Inspired by the challenges of adapting Mono and Flux types in coroutine-based projects, these additions aim to simplify and streamline asynchronous database operations for Kotlin developers. Thank you for the opportunity to contribute to such a valuable framework, and I look forward to your feedback!

Best regards

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 6, 2024
@sdeleuze sdeleuze self-assigned this Nov 7, 2024
@sdeleuze sdeleuze added type: enhancement A general enhancement theme: kotlin An issue related to Kotlin support labels Nov 7, 2024
@sdeleuze
Copy link
Contributor

sdeleuze commented Nov 7, 2024

Hi, thanks for this proposed contribution.

After reviewing it, I am not sure it is following the usual pattern we tend to adopt. As we already expose a flow() extension, I would suggest to use flow().toList() for such need.

Any thoughts?

@sdeleuze sdeleuze added the status: waiting-for-feedback We need additional information before we can continue label Nov 7, 2024
@Yaklede
Copy link
Contributor Author

Yaklede commented Nov 7, 2024

Thank you for ur feedback!
As you suggested, it seems correct to modify that part to use flow.toList(). I’ll make the adjustment!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 7, 2024
@sdeleuze sdeleuze added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Nov 7, 2024
@sdeleuze sdeleuze closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants