Document that Spring Boot will auto-configure RestClient.Builder beans with the observation registry
#33857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ans with the observation registry See spring-projects/spring-boot#38500
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the suggestion but if this needs to be described, it should be in the Spring Boot reference doc. |
snicoll
added
status: declined
quaff
added a commit
to quaff/spring-framework
that referenced
this pull request
Nov 11, 2024
…gistry" from document >> it should be in the Spring Boot reference doc. See spring-projects#33857 (comment)
|
@bclozel see the above for context. I am reopening to get some more feedback as they are other places within our ref doc that have such references. |
snicoll
added
status: waiting-for-triage
|
While we always work towards consistency, I find this PR very frustrating to deal with. The former sentence came from an actual discussion with a library maintainer in #29904. I don't think dedicating our time to discussing this is time well spent. |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See spring-projects/spring-boot#38500