Skip to content

Refactor: Use HttpStatus.Series instead of magic value. #34266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor: Use HttpStatus.Series instead of magic value. #34266

wants to merge 1 commit into from

Conversation

@remeio
Copy link
Contributor

@remeio remeio commented Jan 15, 2025

JUST refactor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 15, 2025
@sdeleuze sdeleuze self-assigned this Jan 15, 2025
@sdeleuze sdeleuze added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jan 15, 2025
@sdeleuze
Copy link
Contributor

Hi thanks for your contribution. IMO it introduces some unnecessary coupling between DefaultHttpStatusCode and HttpStatus, and the eager parsing and storing of HttpStatus.Series is likely not something we want. As a consequence, I will decline this PR.

@sdeleuze sdeleuze closed this Jan 16, 2025
@sdeleuze sdeleuze added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sdeleuze sdeleuze

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@remeio @sdeleuze @spring-projects-issues