Skip to content

Fix "rowsExpected" of SqlQuery is unused #34502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix "rowsExpected" of SqlQuery is unused #34502

wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Feb 27, 2025

No description provided.

@quaff
Copy link
Contributor Author

quaff commented Feb 27, 2025

On the other hand, I don't think it's valuable, we should deprecate it for removal.
See https://github.com/spring-projects/spring-framework/compare/main...quaff:patch-106?expand=1

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 27, 2025
@bclozel
Copy link
Member

bclozel commented Feb 27, 2025

I don't understand the goal of this PR. Maybe create a new issue explaining the problem before suggesting changes?

@bclozel bclozel closed this Feb 27, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 27, 2025
@quaff
Copy link
Contributor Author

quaff commented Feb 28, 2025

I thought it's obvious, rowsExpected is never used, then we have two options:

  1. use it for query.
  2. deprecate it for removal.

@quaff quaff mentioned this pull request Feb 28, 2025
Closed
@quaff
Copy link
Contributor Author

quaff commented Feb 28, 2025

I don't understand the goal of this PR. Maybe create a new issue explaining the problem before suggesting changes?

I created GH-34512 as you requested.

@sbrannen sbrannen added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in: data Issues in data modules (jdbc, orm, oxm, tx) status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quaff @bclozel @sbrannen @spring-projects-issues