Exclude the duplicate media types in AbstractMessageConverterMethodProcessor::determineCompatibleMediaTypes #34785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocessor::determineCompatibleMediaTypes Signed-off-by: Guoxiong Li <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
I'm not sure it's that simple as the selected media type may have a quality parameter, and removing some even if duplicate may change the result. Is there a specific issue that this is causing? |
rstoyanchev
added
status: waiting-for-feedback
I debuged the code and found the duplicate items. It doesn't cause a bug locally. |
spring-projects-issues
added
status: feedback-provided
|
Thanks for clarifying. Eliminating duplicates could have a side effect since media types can have parameters. At the same duplicates do not affect the outcome since we expect a single media type to be chosen, so I'm going to decline this. |
rstoyanchev
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This trivial patch excludes the duplicate media types in the method
AbstractMessageConverterMethodProcessor::determineCompatibleMediaTypes.Thanks for your review.
Best Regards,
-- Guoxiong