Skip to content

Define nullability @Contract for quote and getFilename in StringUtils #34896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Define nullability @Contract for quote and getFilename in StringUtils #34896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spring-core/src/main/java/org/springframework/util/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,7 @@ public static String deleteAny(String inString, @Nullable String charsToDelete)
* @return the quoted {@code String} (for example, "'myString'"),
* or {@code null} if the input was {@code null}
*/
@Contract("null -> null; !null -> !null")
public static @Nullable String quote(@Nullable String str) {
return (str != null ? "'" + str + "'" : null);
}
Expand Down Expand Up @@ -618,6 +619,7 @@ private static String changeFirstCharacterCase(String str, boolean capitalize) {
* @param path the file path (may be {@code null})
* @return the extracted filename, or {@code null} if none
*/
@Contract("null -> null; !null -> !null")
public static @Nullable String getFilename(@Nullable String path) {
if (path == null) {
return null;
Expand Down
Loading