Make ProblemDetailJacksonXmlMixin compatible with Jackson 3
#34925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdeleuze
added
in: web
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
May 26, 2025
|
@rstoyanchev Merged as discussed. I am still unsure what to do about this comment, not sure if that's apply only to Jackson 2. Let's maybe see based on the feedback on Jackson 3 support since our tests are green and update before GA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #33798 and FasterXML/jackson-dataformat-xml#757 (comment), this PR intends to make
ProblemDetailJacksonXmlMixincompatible with Jackson 3.@rstoyanchev Could you please check if the proposed solution is fine or not? I am unsure given the Javadoc comment mentioning that due to FasterXML/jackson-dataformat-xml#355,
@JsonRootNamecan't be used. But in Jackson 3,JacksonXmlRootElementis deprecated and the tests are green with Jackson 3 +@JsonRootName, so I would need your feedback to know if this can be merged or not. I will refine the potentially outdated Javadoc based on your feedback.