PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin
#34978
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| "-Xlint:empty", | ||
| "-Xlint:finally", | ||
| "-Xlint:overrides", | ||
| "-Xlint:path", |
There was a problem hiding this comment.
promotes block format having one thing only (per line).
| import org.gradle.api.tasks.SkipWhenEmpty; | ||
| import org.gradle.api.tasks.TaskAction; | ||
|
|
||
| import static org.springframework.build.architecture.ArchitectureRules.allPackagesShouldBeFreeOfTangles; |
|
|
||
| static ArchRule noClassesShouldCallStringToLowerCaseWithoutLocale() { | ||
| return ArchRuleDefinition.noClasses() | ||
| .should() |
There was a problem hiding this comment.
this indentations seems a little bit too much. questioning current tooling.
| */ | ||
| public void apply(Project project) { | ||
| project.getPlugins().withType(JavaBasePlugin.class, (_) -> { | ||
| project.getPlugins().apply(com.diffplug.gradle.spotless.SpotlessPlugin.class); |
There was a problem hiding this comment.
Cannot resolve symbol 'SpotlessPlugin'
|
is this any good? @bclozel if so would need help on the plugin import. thanks. |
|
Thanks for the proposal but we are not interested in Maven Spotless at the moment. |
bclozel
added
status: declined
|
agree upon, thanks for teaching me about this auto format solution for check. Might be something to go beyond the idea limitation bound into: @romani Its nice to have auto fix but only for IDEA users seems short. As this tool is limited to spring style, it might not fit for desired check style. |
|
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-web/src/main/java/org/springframework/http/converter/ResourceHttpMessageConverter.java:19:8: Unused import - java.io.FileNotFoundException. [UnusedImports] how to apply ? simply building is not fixing simply flaws like quarkus build by using similar plugin. its slowing down development. |
3 participants
give demo for Spotless auto fix capability. Its nice to see that check is, by dedicated plugin, highly integrated.
Never the less haven not spotted yet some problems solver for the issues being pointed out by static code analysis.
Spot integrates nifty providing numerous styles out of the box. Having the whole codebase on the fingertips with this capable plugin.
Eclipse Formatter ProfileintoMaven Spotless Pluginquarkusio/quarkus#48041importOrderwithMaven Spotless Pluginpmd/pmd#5776