Skip to content

Polish DataBufferInputStream.skip() #35030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polish DataBufferInputStream.skip() #35030

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jun 11, 2025

The removed Math.min() seems to be redundant due to the above Math.min().

See gh-34799

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 11, 2025
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Jun 12, 2025
@sbrannen sbrannen requested a review from bclozel June 12, 2025 08:13
DhruvTheDev1
DhruvTheDev1 reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@DhruvTheDev1 DhruvTheDev1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - skiped is already capped by available(), so no need to check again so removing that extra Math.min cleans up the code.

@bclozel bclozel self-assigned this Jun 13, 2025
@bclozel bclozel added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 13, 2025
@bclozel bclozel added this to the 7.0.0-M7 milestone Jun 13, 2025
@bclozel bclozel closed this in 722333f Jun 13, 2025
@bclozel bclozel modified the milestones: 7.0.0-M7, 6.2.9 Jun 13, 2025
@bclozel
Copy link
Member

bclozel commented Jun 13, 2025

Thanks @izeye !

@izeye izeye deleted the gh-34799 branch June 13, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclozel bclozel Awaiting requested review from bclozel

1 more reviewer

@DhruvTheDev1 DhruvTheDev1 DhruvTheDev1 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@bclozel bclozel

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
6.2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@izeye @bclozel @DhruvTheDev1 @sbrannen @spring-projects-issues