Skip to content

Declare messageSelector parameters in JmsOperations as @Nullable #35151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Declare messageSelector parameters in JmsOperations as @Nullable #35151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spring-jms/src/main/java/org/springframework/jms/core/JmsOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ void convertAndSend(String destinationName, Object message, MessagePostProcessor
* @return the message received by the consumer, or {@code null} if the timeout expires
* @throws JmsException checked JMSException converted to unchecked
*/
@Nullable Message receiveSelected(String messageSelector) throws JmsException;
@Nullable Message receiveSelected(@Nullable String messageSelector) throws JmsException;

/**
* Receive a message synchronously from the specified destination, but only
Expand All @@ -252,7 +252,7 @@ void convertAndSend(String destinationName, Object message, MessagePostProcessor
* @return the message received by the consumer, or {@code null} if the timeout expires
* @throws JmsException checked JMSException converted to unchecked
*/
@Nullable Message receiveSelected(Destination destination, String messageSelector) throws JmsException;
@Nullable Message receiveSelected(Destination destination, @Nullable String messageSelector) throws JmsException;

/**
* Receive a message synchronously from the specified destination, but only
Expand All @@ -266,7 +266,7 @@ void convertAndSend(String destinationName, Object message, MessagePostProcessor
* @return the message received by the consumer, or {@code null} if the timeout expires
* @throws JmsException checked JMSException converted to unchecked
*/
@Nullable Message receiveSelected(String destinationName, String messageSelector) throws JmsException;
@Nullable Message receiveSelected(String destinationName, @Nullable String messageSelector) throws JmsException;


//---------------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion spring-jms/src/main/java/org/springframework/jms/core/JmsTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ public void convertAndSend(
}

@Override
public @Nullable Message receiveSelected(String messageSelector) throws JmsException {
public @Nullable Message receiveSelected(@Nullable String messageSelector) throws JmsException {
Destination defaultDestination = getDefaultDestination();
if (defaultDestination != null) {
return receiveSelected(defaultDestination, messageSelector);
Expand Down