Detect Informix error codes as DuplicateKeyException

[sgflt]

This fix is related to #29950 and #29699 .

After migration from Spring Boot 2 to Spring Boot 3 spring-jdbc changed behavior and now throws DataIntegrityViolationException instead of DuplicateKeyException.

[sbrannen]

Hi @sgflt,

Congratulations on submitting your first PR for the Spring Framework! 👍

This is indeed related to #29950, especially this comment (#29950 (comment)).

In sql-error-codes.xml, we support the following for duplicate keys.

spring-framework/spring-jdbc/src/main/resources/org/springframework/jdbc/support/sql-error-codes.xml

Lines 154 to 156 in 942fbf3

	<property name="duplicateKeyCodes">
	<value>-239,-268,-6017</value>
	</property>

The first two are still documented as error codes for Informix 15.

-239	Could not insert new row - duplicate value in a UNIQUE INDEX
column.

The row that is being inserted (or being updated to have a new primary key)
contains a duplicate value of some row that already exists, in a column or
columns that are constrained to have unique values. Another cause of this
error might be a locking conflict if the table lock mode is page. The new
or updated row is not inserted.

Roll back the current transaction and execute it again without any
duplicate rows or with the locking conflict resolved.

If you are using repeatable read isolation, then the error could be due
to a unique constraint being violated. Refer to error -268.

-268	Unique constraint <constraint-name> violated.

During execution of this statement, a duplicate value was introduced
into a column or columns that a unique constraint protects. The row
with the duplicate value was not allowed into the table (not inserted
or not updated). For IBM Informix Dynamic Server, any changes that this statement
made prior to the discovery of the duplicate value have been rolled back. (The
effects of preceding statements in the transaction, if there were any, remain
in effect. They must be explicitly rolled back or committed.)

This error occurs in a logging database. However, if you are using
repeatable read isolation, error -239 will display instead.

Thus, if we were to make this change, I believe we should do it for -239 and -268.

In addition, we would want to do this not only for SQLStateSQLExceptionTranslator (in spring-jdbc) but also for ConnectionFactoryUtils (in spring-r2dbc), and we would need appropriate tests/assertions in SQLStateSQLExceptionTranslatorTests and ConnectionFactoryUtilsTests, respectively.

We will discuss within the team whether we wish to make these changes to SQLStateSQLExceptionTranslator and ConnectionFactoryUtils, and we will let you know whether to proceed with this PR.

---

Note, however, that we would only implement this change for 6.2.x and 7.0.

For 6.0.x and 6.1.x, see the recommendations in Upgrading From Spring Framework 5.3.

Spring's default JDBC exception translator is the JDBC 4 based SQLExceptionSubclassTranslator now, detecting JDBC driver subclasses as well as common SQL state indications (without database product name resolution at runtime). As of 6.0.3, this includes a common SQL state check for DuplicateKeyException, addressing a long-standing difference between SQL state mappings and legacy default error code mappings.

For full backwards compatibility with database-specific error codes, consider re-enabling the legacy SQLErrorCodeSQLExceptionTranslator. This translator kicks in for user-provided sql-error-codes.xml files. It can simply pick up Spring's legacy default error code mappings as well when triggered by an empty user-provided file in the root of the classpath.

[sbrannen]

We have decided to proceed with this.

@sgflt, please update this PR as outlined below.

Thanks

Thus, if we were to make this change, I believe we should do it for -239 and -268.

In addition, we would want to do this not only for SQLStateSQLExceptionTranslator (in spring-jdbc) but also for ConnectionFactoryUtils (in spring-r2dbc), and we would need appropriate tests/assertions in SQLStateSQLExceptionTranslatorTests and ConnectionFactoryUtilsTests, respectively.

[github-actions]

Fixed via db9e938

[sbrannen]

This has been merged into 6.2.x and main in db9e938 and slightly revised in 02f0f92.

Thanks