Interface client refinements #35447
Closed
Interface client refinements #35447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `AbstractHttpServiceRegistrar.findHttpServices(...)` a protected method so that subclasses can use it to find bean definitions. The method was made `private` in commit 736383e, but is still useful even with the removal of `@HttpClientService`. See spring-projectsgh-35447
Update `@ImportHttpServices` to support convention based imports when neither types or base packages are specified. This update allows `@ImportHttpServices` to work in a similar way to `@ComponentScan` where the annotation alone is enough to find HTTP interface clients. For example: package com.example; @configuration @ImportHttpServices(group = "test") static class MyConfig { // this config scans for interface clients in `com.example` } See spring-projectsgh-35447
Update `@ImportHttpServices` to allow the group to either be specified using the `group` attribute or a `groupProvider` implementation. Using a `groupProvider` allows the group name to be deduced from the class metadata. For example, users could use a custom annotation to hold the group name. Groups must either be specified using the `group` attribute *or* the `groupProvider` attribute. Attempting to set both will cause an `IllegalStateException` to be thrown. See spring-projectsgh-35447
Make `ImportHttpServiceRegistrar` a public class and also allow subclasses to call `registerHttpServices(...)`. This update allows Spring Boot to reuse `ImportHttpServiceRegistrar` for convention based auto-configuration. See spring-projectsgh-35447
philwebb
force-pushed
the
interface-client-refinements
branch
from
c5776c0 to
f3b3192
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
Closing since we need more discussion time on these issues and they may need to wait until after Spring Framework 7.0 at this point. |
bclozel
removed
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request provides a number of possible refinements to interface client support, primarily to help with Spring Boot support.
The following commits are included:
@ImportHttpServicesimportsImportHttpServices.GroupProvidersupportImportHttpServiceRegistrarpublic