Add @Nullable annotation to AbstractJsonPathAssertions.isEqualTo #35448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rlaope
force-pushed
the
patch-1
branch
2 times, most recently
from
37fdacc to
3a0acd8
Compare
…meter Signed-off-by: Hope Kim <[email protected]> Signed-off-by: khope <[email protected]>
Signed-off-by: khope <[email protected]>
Signed-off-by: khope <[email protected]>
Signed-off-by: khope <[email protected]>
Signed-off-by: khope <[email protected]>
sdeleuze
added
in: test
|
This PR is hardly usable as not against the branch where we are asked to fix the issue originally, multiple draft commits not squashed, etc. We appreciate contributions but maybe for your next potential try, please take the time to polish it before sending it, and for straightforward changes where we mention in the issue that we will take care, not needed to send a PR that will take more time for us to integrate than directly do the fix. Better to choose non assigned issues that we don't have the time to process. As a consequence, I will close this PR unmerged and reopen the issue. |
sdeleuze
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #35445
This PR adds the @nullable annotation to the parameter of
AbstractJsonPathAssertions.isEqualTo(Object expectedValue).
Also adds a test to verify that passing null works as expected.