Skip to content

Add MediaType.IMAGE_WEBP and IMAGE_WEBP_VALUE #35458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add MediaType.IMAGE_WEBP and IMAGE_WEBP_VALUE #35458

wants to merge 7 commits into from

Conversation

@Dongnyoung
Copy link
Contributor

Hello,

Motivation

image/webp is a widely adopted media type across browsers, CDNs, and mobile platforms.
Currently, developers often hardcode "image/webp" in produces declarations.
Adding MediaType.IMAGE_WEBP and IMAGE_WEBP_VALUE improves consistency with other image media types and avoids string literals.

Changes

  • Added MediaType.IMAGE_WEBP and IMAGE_WEBP_VALUE in spring-web.
  • Javadoc aligned with existing constants (e.g. IMAGE_PNG_VALUE).
  • Added MediaTypeTests#imageWebpConstants for verification.

Compatibility

  • Additive change only.
  • No behavior changes, no removals, fully backwards compatible.

Thanks for the review!

Dongnyoung added 7 commits May 6, 2025 20:12
@Dongnyoung
Fix grammatical error in JavaDoc of setResponse method in MockClientH…
05c3666 
…ttpRequest

This pull request fixes a grammatical mistake in the JavaDoc of the setResponse method in MockClientHttpRequest.

- Original: "the this request"
- Changed to: "this request"

This change improves the clarity and quality of the documentation.

Signed-off-by: DongNyoung Lee <[email protected]>
@Dongnyoung
Merge pull request #2 from Dongnyoung/fix/javadoc-typo
2b29df5 
Fix grammatical error in JavaDoc of setResponse method in MockClientHttpRequest.
@Dongnyoung
Merge branch 'spring-projects:main' into main
ec4390b
@Dongnyoung
Merge branch 'spring-projects:main' into main
f19652a
@Dongnyoung
Update MediaType.java
fedfc7c 
Signed-off-by: DongNyoung Lee <[email protected]>
@Dongnyoung
Update MediaTypeTests.java
0557de4 
Signed-off-by: DongNyoung Lee <[email protected]>
@Dongnyoung
Merge pull request #3 from Dongnyoung/Dongnyoung-mediaType-1-1
045ead7 
Update MediaTypeTests.java
@bclozel
Copy link
Member

bclozel commented Sep 10, 2025

Thanks for the suggestion, but these days we're trying to keep the number of values low here - even if the media type is well known, we tend to add values only if Spring uses it for building a specific feature or support.

See #29613 #26087 #25491 #2055 #1589 #1054 and more

@bclozel bclozel closed this Sep 10, 2025
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dongnyoung @bclozel