Skip to content

Optimize repeated annotation stream processing in cache annotation parsing #35599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+15 −8
Closed

Optimize repeated annotation stream processing in cache annotation parsing #35599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions ...ntext/src/main/java/org/springframework/cache/annotation/SpringCacheAnnotationParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
* @author Phillip Webb
* @author Stephane Nicoll
* @author Sam Brannen
* @author Kamil Krzywański
* @since 3.1
*/
@SuppressWarnings("serial")
Expand Down Expand Up @@ -93,14 +94,20 @@ public boolean isCandidateClass(Class<?> targetClass) {
}

Collection<CacheOperation> ops = new ArrayList<>(1);
annotations.stream().filter(Cacheable.class::isInstance).map(Cacheable.class::cast).forEach(
cacheable -> ops.add(parseCacheableAnnotation(ae, cachingConfig, cacheable)));
annotations.stream().filter(CacheEvict.class::isInstance).map(CacheEvict.class::cast).forEach(
cacheEvict -> ops.add(parseEvictAnnotation(ae, cachingConfig, cacheEvict)));
annotations.stream().filter(CachePut.class::isInstance).map(CachePut.class::cast).forEach(
cachePut -> ops.add(parsePutAnnotation(ae, cachingConfig, cachePut)));
annotations.stream().filter(Caching.class::isInstance).map(Caching.class::cast).forEach(
caching -> parseCachingAnnotation(ae, cachingConfig, caching, ops));
for (Annotation annotation : annotations) {
if (annotation instanceof Cacheable cacheable) {
ops.add(parseCacheableAnnotation(ae, cachingConfig, cacheable));
}
if (annotation instanceof CacheEvict cacheEvict) {
ops.add(parseEvictAnnotation(ae, cachingConfig, cacheEvict));
}
if (annotation instanceof CachePut cachePut) {
ops.add(parsePutAnnotation(ae, cachingConfig, cachePut));
}
if (annotation instanceof Caching caching) {
parseCachingAnnotation(ae, cachingConfig, caching, ops);
}
}
return ops;
}

Expand Down
Loading