#34788 - HierarchicalUriComponents can handle repeated params in a query #35658
+144
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…ated spring-projects#34788 - Use List<QueryParam> instead of MultiValueMap in HierarchicalUriComponents to record query params Signed-off-by: Fabrice Bibonne <[email protected]>
FBibonne
force-pushed
the
gh-34788-uriComponentWithDulpicatedKeys
branch
from
9c5a475 to
742fedd
Compare
|
Solves #34788 |
FBibonne
changed the title
Signed-off-by: Fabrice Bibonne <[email protected]>
- fix MockHttpServletRequestBuilderTests#queryParameterWithoutValues Signed-off-by: Fabrice Bibonne <[email protected]>
- order of params change in result expressions in a few tests : expected results have to be changed Signed-off-by: Fabrice Bibonne <[email protected]>
|
While working on the PR I had to fix some tests, not directly related to URI compononents, like RequestLoggingFilterTests::queryStringIncluded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use List instead of MultiValueMap in HierarchicalUriComponents to record query params