Modernize java.time API usages

[Pankraz76]

I’d kindly like to suggest considering Error Prone integration featuring the TimeRules findings:

As discussed in:

• Add rewrite support for errorprone.refasterrules #35270

PS:

Congratulations on the recent major release — a lot of work has clearly gone into it.
I'm sure Spring Boot will continue to succeed as well.

Changes have been made to spring-context/src/main/java/org/springframework/scheduling/support/CronTrigger.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-context/src/main/java/org/springframework/format/datetime/standard/DateTimeConverters.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-context/src/test/java/org/springframework/scheduling/concurrent/DefaultManagedTaskSchedulerTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfMinutesRecipe
Changes have been made to spring-test/src/main/java/org/springframework/test/http/HttpHeadersAssert.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-test/src/test/java/org/springframework/test/web/servlet/result/HeaderResultMatchersTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-test/src/test/java/org/springframework/test/web/servlet/client/RestTestClientTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-test/src/test/java/org/springframework/test/web/support/HeaderAssertionTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-web/src/main/java/org/springframework/web/server/session/InMemoryWebSessionStore.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcClockRecipe
Changes have been made to spring-web/src/main/java/org/springframework/http/HttpHeaders.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-web/src/test/java/org/springframework/web/server/i18n/FixedLocaleContextResolverTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-web/src/test/java/org/springframework/http/client/reactive/ClientHttpConnectorTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultRenderingResponseTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfMillisRecipe
Changes have been made to spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/HttpEntityMethodProcessorMockTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Please review and commit the results.
Estimate time saved: 1h 10m

[mdeinum]

Looking at existing rules and deliberate care in dependencies I would expect some changes. Which would mean that the rewrite rules aren't applicable.

[Pankraz76]

Looking at existing rules and deliberate care in dependencies I would expect some changes. Which would mean that the rewrite rules aren't applicable.

Thank you for the kind feedback.

I’ve reworked the scope to focus on the TimeRules. Hopefully this is something easier to consider.

the rewrite rules aren't applicable.

I think it’s difficult to judge something universally or generically; each scope has its own individual context.

This is the first project that passed the included GradleBestPractices checks without any findings.
That suggests the codebase is already very up-to-date regarding this scope — well done.

Considering the Java8toJava11 migration, as explored in

• [rewrite] Add Java8toJava11 Pankraz76/spring-framework#3
• [rewrite] Add UpgradeToJava17 Pankraz76/spring-framework#4

the code compiles on Java 21+ while still largely using Java 8–era and Java 17–era constructs.
That’s something to consider — similar to how Checkstyle, Google Error Prone, and Spotless have already done clean up the entire codebase in a glance.

[sdeleuze]

We prefer to not introduce new tooling infrastructure in our build, please refine this PR to only include the .*java changes.

[Pankraz76]

yes of course, thanks for the kind feedback.

[rickie]

Looks good! Thanks for applying @Pankraz76

[sdeleuze]

Merged with some important changes in HttpHeaders (see dc0c463), next time please make sure the tests are green before submitting your PR. Thanks for your contribution.