Skip to content

Support using DataLoader from suspend function #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support using DataLoader from suspend function #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .../src/main/java/org/springframework/graphql/data/method/InvocableHandlerMethodSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import graphql.GraphQLContext;
import io.micrometer.context.ContextSnapshot;
import org.springframework.data.util.KotlinReflectionUtils;
import reactor.core.publisher.Mono;

import org.springframework.core.CoroutinesUtils;
Expand Down Expand Up @@ -81,7 +82,18 @@ protected Object doInvoke(GraphQLContext graphQLContext, Object... argValues) {
Method method = getBridgedMethod();
try {
if (KotlinDetector.isSuspendingFunction(method)) {
return CoroutinesUtils.invokeSuspendingFunction(method, getBean(), argValues);
Object result = CoroutinesUtils.invokeSuspendingFunction(method, getBean(), argValues);

Class<?> returnType = KotlinReflectionUtils.getReturnType(method);

if (CompletableFuture.class.isAssignableFrom(returnType)) {
@SuppressWarnings("unchecked")
Mono<CompletableFuture<?>> mono = (Mono<CompletableFuture<?>>)result;
// Unwrap nested CompletableFuture
return mono.flatMap(Mono::fromFuture);
}
Comment on lines +87 to +94
Copy link
Contributor Author

@koenpunt koenpunt Mar 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inspired by the code in CoroutinesUtils; https://github.com/spring-projects/spring-framework/blob/254fb3956727f22e8e5f4e61cd1153b1d5bff93b/spring-core/src/main/java/org/springframework/core/CoroutinesUtils.java#L112-L122


return result;
}
Object result = method.invoke(getBean(), argValues);
return handleReturnValue(graphQLContext, result);
Expand Down