#8: Codec support #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dsyer
reviewed
Oct 19, 2024
...ain/java/org/springframework/grpc/autoconfigure/client/GrpcChannelFactoryConfigurations.java
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Member
|
If you could squash your changes into one commit that would also be helpful. |
Contributor
Also, a small description for the PR would be most welcomed. |
onobc
requested changes
Oct 19, 2024
Contributor
onobc
left a comment
onobc
left a comment
There was a problem hiding this comment.
Thanks @andreilisa for this contribution. Nice work! It may look like I added a bunch of comments/suggestions but they are mostly of the nit variety.
...ain/java/org/springframework/grpc/autoconfigure/client/GrpcChannelFactoryConfigurations.java
Show resolved
Hide resolved
...src/main/java/org/springframework/grpc/autoconfigure/client/GrpcClientAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecAutoConfiguration.java
Outdated
Show resolved
Hide resolved
andreilisa
force-pushed
the
8-codec-support
branch
from
a2a8fbf to
786951e
Compare
onobc
reviewed
Oct 20, 2024
...rc/main/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecConfiguration.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Oct 20, 2024
...rc/main/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecConfiguration.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Oct 20, 2024
...rc/main/java/org/springframework/grpc/autoconfigure/common/codec/GrpcCodecConfiguration.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Oct 20, 2024
.../src/test/java/org/springframework/grpc/autoconfigure/common/GrpcCodecConfigurationTest.java
Show resolved
Hide resolved
onobc
reviewed
Oct 20, 2024
.../src/test/java/org/springframework/grpc/autoconfigure/common/GrpcCodecConfigurationTest.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Oct 20, 2024
.../src/test/java/org/springframework/grpc/autoconfigure/common/GrpcCodecConfigurationTest.java
Outdated
Show resolved
Hide resolved
onobc
requested changes
Oct 20, 2024
Contributor
onobc
left a comment
onobc
left a comment
There was a problem hiding this comment.
Thanks for the quick updates @andreilisa . We are almost there. A few minor comments/suggestions.
dsyer
requested changes
Oct 20, 2024
Member
dsyer
left a comment
dsyer
left a comment
There was a problem hiding this comment.
Nearly there. Just the nitpicks from Chris as far as I can tell. Plus you might need to rebase and force push (and then you could squash at the same time) to make it a clean merge.
Contributor
Author
|
If there aren't any TinyNits let me know and I will do the squash |
Member
|
LGTM. Please rebase and squash. |
andreilisa
force-pushed
the
8-codec-support
branch
from
9bcfb85 to
2fe2ee3
Compare
andreilisa
force-pushed
the
8-codec-support
branch
from
57c8327 to
b60bbc3
Compare
Contributor
Author
|
@dsyer, It looks better now |
Contributor
|
Nice work @andreilisa ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for gRPC compression and decompression codecs by auto-configuring CompressorRegistry and DecompressorRegistry beans. It registers available Compressor and Decompressor instances with the corresponding registries.