Remove unnecessary dependency exclusions #310
Merged
+0
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unnecessary exclusions of Google
protobuf-javaandproto-google-common-protosdependencies fromspring-grpc-coreandspring-grpc-dependenciesmodules as the desired versions are properly overridden without the exclusions.Details
In digging into whether we should bump the Google protobuf and common protos libs, I revisited the exclusions we had in several POMs and as it turns out we do not need them in there. The dependencyManagement does its job and overrides the transitive Google protobuf-java and proto-common-google-protos to the expected versions.
We are expecting the following:
And after running these changes locally and issuing the following commands you can see the versions are all as expected:
Produces all
1.77.0sProduces all
4.32.1sProduces all
2.61.2s