Skip to content

Conversation

@onobc
Copy link
Contributor

@onobc onobc commented Dec 3, 2025

This removes unnecessary exclusions of Google protobuf-java and proto-google-common-protos dependencies from spring-grpc-core and spring-grpc-dependencies modules as the desired versions are properly overridden without the exclusions.

Details

In digging into whether we should bump the Google protobuf and common protos libs, I revisited the exclusions we had in several POMs and as it turns out we do not need them in there. The dependencyManagement does its job and overrides the transitive Google protobuf-java and proto-common-google-protos to the expected versions.

We are expecting the following:

  • io.grpc:grpc-protobuf:1.77.0
  • com.google.protobuf:protobuf-java:4.32.1
  • com.google.api.grpc:proto-google-common-protos:2.61.2

And after running these changes locally and issuing the following commands you can see the versions are all as expected:

DEP="io.grpc:grpc-protobuf"
./mvnw dependency:tree -Dverbose -Dincludes="$DEP" | grep -E "$DEP"

Produces all 1.77.0s

DEP="com.google.protobuf:protobuf-java"
./mvnw dependency:tree -Dverbose -Dincludes="$DEP" | grep -E "$DEP"

Produces all 4.32.1s

DEP="com.google.api.grpc:proto-google-common-protos"
./mvnw dependency:tree -Dverbose -Dincludes="$DEP" | grep -E "$DEP"

Produces all 2.61.2s

This removes unnecessary exclusions of Google `protobuf-java` and
`proto-google-common-protos` dependencies from `spring-grpc-core` and
`spring-grpc-dependencies` modules as the desired versions are
properly overridden without the exclusions.

Signed-off-by: onobc <[email protected]>
@onobc onobc requested a review from dsyer December 3, 2025 04:56
@onobc onobc added this to the 1.0.0 milestone Dec 3, 2025
@onobc onobc added dependencies Pull requests that update a dependency file type: task and removed dependencies Pull requests that update a dependency file labels Dec 3, 2025
@onobc onobc mentioned this pull request Dec 3, 2025
@dsyer dsyer merged commit 85ca98b into spring-projects:main Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants