Allow named channels to inherit default configuration #347
+323
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-shevchenko
force-pushed
the
gh-345
branch
2 times, most recently
from
707a333 to
1218da9
Compare
Named channels now inherit settings from default-channel configuration. Explicitly configured values in named channels take precedence over defaults. Implements mergeWith() method in ChannelConfig that merges configurations using Optional.ofNullable().orElse() pattern for null-safe value selection. Adds ChannelInheritanceAPI tests to verify inheritance behavior. [resolves spring-projects#345] Signed-off-by: Oleksandr Shevchenko <shevchenko.olexandr96@gmail.com> Signed-off-by: Oleksandr Shevchenko <oleksandr.shevchenko@datarobot.com>
o-shevchenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named channels now inherit settings from default configuration. Explicitly configured values in named channels take precedence over defaults.
[resolves #345]