Apply Nullability to spring-integration-jpa
#10157
Conversation
related to: spring-projects#10083 Signed-off-by: Jiandong Ma <[email protected]>
...rc/main/java/org/springframework/integration/jpa/outbound/JpaOutboundGatewayFactoryBean.java
Outdated
Show resolved
Hide resolved
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
Signed-off-by: Jiandong Ma <[email protected]>
| this.flushSize = 1; | ||
| } | ||
|
|
||
| if (this.evaluationContext == null) { |
There was a problem hiding this comment.
is it harmful to remove in this version?
There was a problem hiding this comment.
I don't think so.
This is major version, so we can have some breaking changes.
But I don't see how this one could be.
There was a problem hiding this comment.
okay, so instead of depredated method setIntegrationEvaluationContext(), can we simply remove that method?
There was a problem hiding this comment.
No. We never remove a public API in our classes just because.
Has to be deprecated first.
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Thank you for the update!
This is very close to the merge.
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Outdated
Show resolved
Hide resolved
| this.flushSize = 1; | ||
| } | ||
|
|
||
| if (this.evaluationContext == null) { |
There was a problem hiding this comment.
I don't think so.
This is major version, so we can have some breaking changes.
But I don't see how this one could be.
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
2 participants
related to: #10083