-
Notifications
You must be signed in to change notification settings - Fork 1.1k
GH-10362: Block on PostgresSubscribableChannel.unsubscribe #10363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, run ./gradlew :spring-integration-jdbc:check
locally before pushing.
It also would be great if you bring some test to cover this logic.
Thanks
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Outdated
Show resolved
Hide resolved
be9d911
to
33dad8d
Compare
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Outdated
Show resolved
Hide resolved
...rg/springframework/integration/jdbc/postgres/PostgresChannelMessageTableSubscriberTests.java
Outdated
Show resolved
Hide resolved
33dad8d
to
f24c917
Compare
Thank you for an update! |
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/jdbc/channel/PostgresSubscribableChannel.java
Show resolved
Hide resolved
...rg/springframework/integration/jdbc/postgres/PostgresChannelMessageTableSubscriberTests.java
Show resolved
Hide resolved
...rg/springframework/integration/jdbc/postgres/PostgresChannelMessageTableSubscriberTests.java
Show resolved
Hide resolved
...rg/springframework/integration/jdbc/postgres/PostgresChannelMessageTableSubscriberTests.java
Outdated
Show resolved
Hide resolved
...rg/springframework/integration/jdbc/postgres/PostgresChannelMessageTableSubscriberTests.java
Outdated
Show resolved
Hide resolved
...rg/springframework/integration/jdbc/postgres/PostgresChannelMessageTableSubscriberTests.java
Outdated
Show resolved
Hide resolved
f24c917
to
25f9bd8
Compare
…ribe Unsubscribing message handlers while processing an in-flight message may lead to a MessageDeliveryException. Fixes: spring-projectsGH-10362 Signed-off-by: Norbert Schneider <[email protected]>
25f9bd8
to
0aa2aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will merge when the PR build is green.
Great! Thanks for your time and support with this PR. |
Merged and cherry-picked to Thank you for contribution; looking forward for more! |
Unsubscribing message handlers while processing an in-flight message may lead to a MessageDeliveryException.
Fixes: GH-10362