Skip to content

Fix typo in camel.adoc #10368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix typo in camel.adoc #10368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/reference/antora/modules/ROOT/pages/camel.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ Therefore, developers may choose one framework over another for many reasons or
Spring Integration and Apache Camel applications can interact with each other through many external protocols for which they implement channel adapters.
For example, a Spring Integration flow may publish a record to an Apache Kafka topic which is consumed by an Apache Camel endpoint on the consumer side.
Or, an Apache Camel route may write data into an SFTP file the directory, which is polled by a SFTP Inbound Channel Adapter from Spring Integration.
Or, within the same Spring application context they can communicate via an `ApplicationEvent` https://camel.apache.org/components/3.18.x/spring-event-component.html[abstraction].
Or, within the same Spring application context they can communicate via an `ApplicationEvent` https://camel.apache.org/components/4.10.x/spring-event-component.html[abstraction].

To make the development process easier and to avoid unnecessary network hops, Apache Camel provides a https://camel.apache.org/components/3.18.x/spring-integration-component.html[module] to communicate with Spring Integration via message channels.
To make the development process easier and to avoid unnecessary network hops, Apache Camel provides a https://camel.apache.org/components/4.10.x/index.html[module] to communicate with Spring Integration via message channels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit that I have missed to fix version for Apache Camel everywhere in this doc.
However, it looks like we have a bigger problem: Apache Camel does not provide Spring Integration module any more: https://camel.apache.org/manual/camel-4-migration-guide.html.

So, we need to revise this doc a bit more.
And as a subsequent task provide an Inbound Channel Adapter instead of the following sentence:

There is no inbound channel adapter because subscribing to a MessageChannel

And as a replacement for the removal of the whole component from Apache Camel.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review!
I hadn't fully realized these issues. I really appreciate your feedback.

Would it be okay to close this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. We will close today when we prepare a replacement PR with reality reflection.

All that is needed is a reference to a `MessageChannel` from the application context, to send or consume messages.
This works well when Apache Camel routes are initiators of the message flow and Spring Integration plays only a supporting role as a part of the solution.

Expand Down