GH-10083: Nullability for graph in core module #10371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Sep 2, 2025
...gration-core/src/main/java/org/springframework/integration/graph/IntegrationGraphServer.java
Outdated
Show resolved
Hide resolved
...gration-core/src/main/java/org/springframework/integration/graph/IntegrationGraphServer.java
Outdated
Show resolved
Hide resolved
...on-core/src/main/java/org/springframework/integration/graph/CompositeMessageHandlerNode.java
Outdated
Show resolved
Hide resolved
...n-core/src/main/java/org/springframework/integration/graph/DiscardingMessageHandlerNode.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/integration/graph/ErrorCapableCompositeMessageHandlerNode.java
Outdated
Show resolved
Hide resolved
...ntegration-core/src/main/java/org/springframework/integration/graph/MessageProducerNode.java
Outdated
Show resolved
Hide resolved
...-integration-core/src/main/java/org/springframework/integration/graph/MessageSourceNode.java
Outdated
Show resolved
Hide resolved
...tion-core/src/main/java/org/springframework/integration/graph/RoutingMessageHandlerNode.java
Outdated
Show resolved
Hide resolved
...gration-core/src/main/java/org/springframework/integration/graph/MicrometerNodeEnhancer.java
Outdated
Show resolved
Hide resolved
...gration-core/src/main/java/org/springframework/integration/graph/IntegrationGraphServer.java
Outdated
Show resolved
Hide resolved
cppwfs
force-pushed
the
GH-10083-core-graph
branch
from
3fa3972 to
10af742
Compare
* Add Nullability to core module's graph package. * `buildGraph` and `getGraph` methods in the `IntegrationGraphServer` because Nullify could not see the creation of the graph * `IntegrationGraphServer.receiptListRoutingHandler` required a change where the messageChannel could not be null in the `map` portion of expression. So it was extracted into a var and the var was checked for null.
* Set AppContext to not be nullable * Consumer's inbound channels are never null. Update to remove nullable * Update outbound channels so they are not nullable * Use local variable trick to work past Nullables inability to see a new above return value * Add contract to channelToBeanName in IntegrationGraphServer
cppwfs
force-pushed
the
GH-10083-core-graph
branch
from
0c03a42 to
ec20eb0
Compare
artembilan
requested changes
Sep 3, 2025
...gration-core/src/main/java/org/springframework/integration/graph/IntegrationGraphServer.java
Outdated
Show resolved
Hide resolved
| @@ -119,8 +123,12 @@ private <T extends IntegrationNode> Timer obtainTimer(T node, String type, boole | |||
| } | |||
| } | |||
|
|
|||
| @Nullable | |||
| private <T extends IntegrationNode> Timer observationTimer(T node, String type, boolean success) { | |||
| private RequiredSearch getRegistry(String name) { | |||
There was a problem hiding this comment.
We don't need this method any more after that NullAway.Init.
And therefore everything else.
artembilan
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildGraphandgetGraphmethods in theIntegrationGraphServerbecause Nullify could not see the creation of the graphIntegrationGraphServer.receiptListRoutingHandlerrequired a change where the messageChannel could not be null in themapportion of expression. So it was extracted into a var and the var was checked for null.