Fix Files DSL for auto-create input directory #10525
Merged
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#7971 The `FileReadingMessageSource` has always had a feature to create a directory to scan on startup. After introducing an expression variant, such a logic is limited only for the `ValueExpression` as only this one comes with a static value. The Java DSL has been changed to support a `Supplier` variant for an input directory. The `Supplier` does not always give us the same value; therefore, we cannot assume directory auto-creation on startup. * Fix `FileInboundChannelAdapterSpec` for the `directory(Expression directoryExpression)` instead of `Supplier` * Fix `Files` to use a `ValueExpression` for statically provided `File directory`
artembilan
added a commit
to spring-projects/spring-integration-samples
that referenced
this pull request
Oct 22, 2025
* Make `ci-snapshot.yml` as scheduled for the night build * Remove the `mkdirs()` in the `file-split-ftp` test as the respective fix is coming in Spring Integration: spring-projects/spring-integration#10525
cppwfs
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #7971
The
FileReadingMessageSourcehas always had a feature to create a directory to scan on startup. After introducing an expression variant, such a logic is limited only for theValueExpressionas only this one comes with a static value.The Java DSL has been changed to support a
Suppliervariant for an input directory. TheSupplierdoes not always give us the same value; therefore, we cannot assume directory auto-creation on startup.FileInboundChannelAdapterSpecfor thedirectory(Expression directoryExpression)instead ofSupplierFilesto use aValueExpressionfor statically providedFile directory