Improve readability of delete and renew methods of DefaultLockRepository
#9619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Oct 30, 2024
| public boolean delete(String lock) { | ||
| return this.defaultTransactionTemplate.execute( | ||
| transactionStatus -> this.template.update(this.deleteQuery, this.region, lock, this.id)) > 0; | ||
| transactionStatus -> this.template.update(this.deleteQuery, this.region, lock, this.id)) == 1; |
Member
There was a problem hiding this comment.
I am not sure what difference with existing style.
How whatever you have done here helps with readability?
Contributor
Author
There was a problem hiding this comment.
I think readers can easily understand that only one lock ownership is expected to be deleted.
Member
There was a problem hiding this comment.
That's debatable. Because you see: for me this does nothing.
However to save both our time discussing this I'll go ahead and merge.
EddieChoCho
deleted the
improve-readability-of-delete-and-renew-methods-of-defaultLockRepository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deletemethod of DefaultLockRepository: improve readabilityrenewmethod of DefaultLockRepository: improve readability