Skip to content

Add AcknowledgementCommitCallback support for async share consumer commits #4380

Description

@sobychacko

Following up on #4324 which adds the syncShareCommits option for share consumer containers, we should consider adding support for AcknowledgementCommitCallback when async commits are used.

Currently when syncShareCommits=false, the container calls commitAsync() (PR #4379) but there's no visibility into whether those commits succeed or fail. The Kafka ShareConsumer API provides setAcknowledgementCommitCallback() for this purpose.

Proposal:

• When async commits are enabled, register a default callback that logs failures
• Optionally expose a way for users to provide their own callback via ContainerProperties for custom error handling

This would give users better observability when opting into async commits for higher throughput.

Related: #4324, PR #4379

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions