Skip to content

GH-3276: Support async retry with @RetryableTopic #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed

GH-3276: Support async retry with @RetryableTopic #3523

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
eee3515
Test
chickenchickenlove Sep 29, 2024
fdc59f0
DRAFT
chickenchickenlove Sep 30, 2024
87ac522
GH-3276: Draft and test codes.
chickenchickenlove Oct 1, 2024
723cc18
Add test cases.
chickenchickenlove Oct 6, 2024
ac110b4
Add method
chickenchickenlove Oct 6, 2024
e30319d
Fixes lint errors.
chickenchickenlove Oct 7, 2024
6399b81
Minimize FailedRecordTuple dependency.
chickenchickenlove Oct 9, 2024
4a4a1ee
Refactor test codes and real codes.
chickenchickenlove Oct 10, 2024
08e7721
Modify method name.
chickenchickenlove Oct 10, 2024
c0fea39
Fixes compile error.
chickenchickenlove Oct 10, 2024
e74072c
Remove async retry callback from MessageListener contract.
chickenchickenlove Oct 11, 2024
645d7ce
Revert Copyright period.
chickenchickenlove Oct 11, 2024
0c89c92
Revert KafkaBackkOffAwareMessageListenerAdapter.
chickenchickenlove Oct 11, 2024
3f6b447
Depends on general type on KafkaMessageListenerContainer.
chickenchickenlove Oct 11, 2024
01de80e
Remove sleep(1) from async retry test.
chickenchickenlove Oct 11, 2024
97f05be
Remove waitAWhile().
chickenchickenlove Oct 12, 2024
d219037
Add java docs.
chickenchickenlove Oct 12, 2024
e8378da
Add author
chickenchickenlove Oct 12, 2024
967a7c4
Fixes flaky test.
chickenchickenlove Oct 12, 2024
f2c67c7
Modify contract of callback for async failure.
chickenchickenlove Oct 14, 2024
56e6fd3
Fixes java docs for setCallbackFroAsyncFailure.
chickenchickenlove Oct 14, 2024
5e70c76
Fix the tests for async failure retry.
chickenchickenlove Oct 15, 2024
1d9f7b9
Remove weed from async retry test and fix lint error.
chickenchickenlove Oct 15, 2024
e418b10
Add Tags for conditional test.
chickenchickenlove Oct 15, 2024
002aaf4
Remove useless tag for async failure retry tests.
chickenchickenlove Oct 15, 2024
3b79d59
Remove unused import
chickenchickenlove Oct 15, 2024
82ecac7
Make a method static and Add @SuppressWarning.
chickenchickenlove Oct 15, 2024
0afae4e
Remove useless latch.
chickenchickenlove Oct 15, 2024
796397f
Use specific ListenerAdapter type for async retry feature.
chickenchickenlove Oct 15, 2024
4e89d53
Fixes lint error.
chickenchickenlove Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...a/org/springframework/kafka/retrytopic/AsyncCompletableFutureRetryTopicScenarioTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.common.serialization.StringSerializer;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

import org.springframework.beans.factory.annotation.Autowired;
Expand Down Expand Up @@ -68,6 +69,7 @@
* @since 3.3.0
*/

@Tag("async-retry-flaky-test")
@SpringJUnitConfig
@DirtiesContext
@EmbeddedKafka
Expand Down
2 changes: 2 additions & 0 deletions .../src/test/java/org/springframework/kafka/retrytopic/AsyncMonoRetryTopicScenarioTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.common.serialization.StringSerializer;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

import org.springframework.beans.factory.annotation.Autowired;
Expand Down Expand Up @@ -69,6 +70,7 @@
* @since 3.3.0
*/

@Tag("async-retry-flaky-test")
@SpringJUnitConfig
@DirtiesContext
@EmbeddedKafka
Expand Down