Add TaskScheduler option for Kafka metrics components
#3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobychacko
requested changes
Oct 17, 2024
Contributor
sobychacko
left a comment
sobychacko
left a comment
There was a problem hiding this comment.
How about a few sentences in the red docs as well, since we are providing some protected api methods that can be overridden?
spring-kafka/src/main/java/org/springframework/kafka/core/KafkaMetricsSupport.java
Outdated
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/core/KafkaMetricsSupport.java
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/core/KafkaMetricsSupport.java
Outdated
Show resolved
Hide resolved
artembilan
force-pushed
the
kafka_metrics_scheduler
branch
from
69e6881 to
cf4a1fb
Compare
sobychacko
approved these changes
Oct 17, 2024
artembilan
force-pushed
the
kafka_metrics_scheduler
branch
from
cf4a1fb to
7a039e5
Compare
Related to: micrometer-metrics/micrometer#4976 * Introduce a `KafkaMetricsSupport` to have a common API for the `MeterBinder` registration * Rework `MicrometerConsumerListener`, `MicrometerProducerListener` and `KafkaStreamsMicrometerListener` to extend the `KafkaMetricsSupport` which allows to minimize code duplication * Expose ctors on those listeners based on the `TaskScheduler` * Implement a simple `ScheduledExecutorServiceAdapter` to adapt a `TaskScheduler` to the expected by the `KafkaMetrics` `ScheduledExecutorService`
…et projects * Add more JavaDocs to the `KafkaMetricsSupport` * Mention `KafkaMetricsSupport` in the docs
artembilan
force-pushed
the
kafka_metrics_scheduler
branch
from
7a039e5 to
e437c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: micrometer-metrics/micrometer#4976
KafkaMetricsSupportto have a common API for theMeterBinderregistrationMicrometerConsumerListener,MicrometerProducerListenerandKafkaStreamsMicrometerListenerto extend theKafkaMetricsSupportwhich allows to minimize code duplicationTaskSchedulerScheduledExecutorServiceAdapterto adapt aTaskSchedulerto the expected by theKafkaMetricsScheduledExecutorService