Skip to content

GH-3638: Fixes bug caused by race condition during handleAsyncFailure(). #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024
Merged

GH-3638: Fixes bug caused by race condition during handleAsyncFailure(). #3639

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa24b47
GH-3638: Fixes bug caused by race condition during handleAsyncFailure().
chickenchickenlove Nov 17, 2024
2c32f76
Fixes lint error.
chickenchickenlove Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,7 +1466,14 @@ protected void pollAndInvoke() {

protected void handleAsyncFailure() {
List<FailedRecordTuple<K, V>> copyFailedRecords = new ArrayList<>(this.failedRecords);
this.failedRecords.clear();

// If we use failedRecords.clear() to remove copied record from failed records,
// We may encounter race condition during this operation.
// Other, the thread which execute this block, may miss one failed record.
int capturedRecordsCount = copyFailedRecords.size();
for (int i = 0; i < capturedRecordsCount; i++) {
this.failedRecords.pollFirst();
}

// If any copied and failed record fails to complete due to an unexpected error,
// We will give up on retrying with the remaining copied and failed Records.
Expand Down